-
Notifications
You must be signed in to change notification settings - Fork 32
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Final edits to the UI strings #1176
base: master
Are you sure you want to change the base?
Conversation
1. Currently unable to chagne the message "VirtualMachine generation is 2..." 2. Discrepency between "cluster flow/flows" etc is out of my control for the UI string changes. Signed-off-by: Alexandra Settle <asettle@suse.com>
You can remove
Same for harvesterhci.io.logging.clusteroutput.vue / flow.vue / output.vue |
Hi @Yu-Jack or @FrankYang0529 , Could you kindly help separate the wording "VirtualMachine" to "Virtual Machine" in harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go ? |
Hi @a110605, we may not be able to do that. harvester/vendor/sigs.k8s.io/cli-utils/pkg/kstatus/status/generic.go is upstream code. Also, VirtualMachine is defined in upstream. |
BTW, it's a |
“VirtualMachine” in “VirtualMachine generation is 2...” means that |
Hmm I understand. That being said, because it's the same text, it looks like a spelling mistake. Can we apply some mark-up to 'VirtualMachine' to ensure it's clear? |
Closes rancher#6407